Refactor cookiecutter hooks and tests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 7 commits
April 27, 2021 13:32
coverage ignores `if __name__ == .__main__.:` statements. flake8 ignores unused imports in `__init__.py` files only. pytest now does not collect anything in the `example` folder. Sphinx can now import `hooks`, and `src` packages directly as they have been added to the system path.
Also ignore the `api` folder in each `docs/reference` folder, as the Sphinx `autosummary` extension will create docstring ReStructuredText files here.
Moved to a new folder called `.govcookiecutter` within the template folder. Also add default AQA documents to the template.
Refactor functions for testability, and use pathlib. Write unit and integration tests to ensure functions operate as expected. As the frameworks now include request templates as well as AQA, re-label the corresponding `cookiecutter.json` variable.
ESKYoung
force-pushed
the
refactor_hooks
branch
from
bf71f67 to
95d60b3
Compare
|
Rebased onto the latest |
Instead declare the `__all__` variable as stated by flake8's maintainer: https://stackoverflow.com/a/59438802
maxf
reviewed
May 21, 2021
maxf
approved these changes
May 21, 2021
{{ cookiecutter.repo_name }}/.govcookiecutter/department_frameworks/README.md
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.govcookiecutterfolder for clarity; this folder is deleted post-generationChecklists
This pull/merge request meets the following requirements:
docsfolderComments have been added below around the incomplete checks.