Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo faults #17

Open
jeanphi-baconnais opened this issue Sep 27, 2022 · 6 comments
Open

Typo faults #17

jeanphi-baconnais opened this issue Sep 27, 2022 · 6 comments
Labels
good first issue Good for newcomers hacktoberfest Feel free to take this one

Comments

@jeanphi-baconnais
Copy link

Month should have not majuscule and 'août' have a circumflex accent.

@besstiolle besstiolle added good first issue Good for newcomers hacktoberfest Feel free to take this one labels Sep 27, 2022
@RohitRajvaidya5
Copy link

I don't understand exactly where is typo faults can you mention exact files, please?
and if yes, can you assign me on this issue?

@jeanphi-baconnais
Copy link
Author

You can find the word "aout" and you will find the file 😉

@besstiolle
Copy link
Owner

export const MONTHS = ['Jan.','Fev.','Mar.','Avr.','Mai','Juin','Juil.','Aout','Sept.','Oct.','Nov.','Dec.']

src/lib/constantes.ts

@RohitRajvaidya5
Copy link

Done!!!

@besstiolle
Copy link
Owner

Sorry RohitRajvaidya5 i must denied your PR.

The subject of this bug #17 was

Month should have not majuscule and 'août' have a circumflex accent.

For now It's a french wording (i'm french), so i'd rather stay with french month without majuscule and with 'août' having a circumflex accent.

But i'm aware that the real fix would be to add a real i18n system like here : #21

So i'll refuse your PR, fix this bug #17 myself and propose to everybody to take a moment on the question of the i18n here : #21

Thank you again for you help

@RohitRajvaidya5
Copy link

I can make desire changes, I didn't about #21 sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Feel free to take this one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants