Merge pull request Expensify#51306 from software-mansion-labs/fix/sel…

…ection-on-ios

iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount

src/components/MoneyRequestAmountInput.tsx

@@ -135,6 +135,8 @@ function MoneyRequestAmountInput(
 
     const textInput = useRef<BaseTextInputRef | null>(null);
 
+    const amountRef = useRef<string | undefined>(undefined);
+
     const decimals = CurrencyUtils.getCurrencyDecimals(currency);
     const selectedAmountAsString = amount ? onFormatAmount(amount, currency) : '';
 
@@ -172,8 +174,9 @@ function MoneyRequestAmountInput(
 
             willSelectionBeUpdatedManually.current = true;
             let hasSelectionBeenSet = false;
+            const strippedAmount = MoneyRequestUtils.stripCommaFromAmount(finalAmount);
+            amountRef.current = strippedAmount;
             setCurrentAmount((prevAmount) => {
-                const strippedAmount = MoneyRequestUtils.stripCommaFromAmount(finalAmount);
                 const isForwardDelete = prevAmount.length > strippedAmount.length && forwardDeletePressedRef.current;
                 if (!hasSelectionBeenSet) {
                     hasSelectionBeenSet = true;
@@ -313,7 +316,10 @@ function MoneyRequestAmountInput(
                 if (!shouldUpdateSelection) {
                     return;
                 }
-                const maxSelection = formattedAmount.length;
+
+                // When the amount is updated in setNewAmount on iOS, in onSelectionChange formattedAmount stores the value before the update. Using amountRef allows us to read the updated value
+                const maxSelection = amountRef.current?.length ?? formattedAmount.length;
+                amountRef.current = undefined;
                 const start = Math.min(e.nativeEvent.selection.start, maxSelection);
                 const end = Math.min(e.nativeEvent.selection.end, maxSelection);
                 setSelection({start, end});