Skip to content

Commit

Permalink
Fix rubocop CI taking forever (#24)
Browse files Browse the repository at this point in the history
* Add .ruby-version file

* Add .ruby-version at 3.3.0 to use rubocop

* Run rubocop autocorrect

* Set rubocop filter mode to file to attempt to fix runtime

* Try reverting rubocop config to fix runtime

* Add rubocop-rspec to rubocop config

* Exclude spec from jekyll build

This way it doesn't appear in _site/ and rubocop doesn't yell at *.rb files in _site (so we don't have to exclude it, which is for some reason causing the rubocop action to run forever)
  • Loading branch information
phrdang authored Jun 19, 2024
1 parent 1aa50e5 commit 50ed272
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 6 deletions.
1 change: 0 additions & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
bundler-cache: true
- uses: reviewdog/action-rubocop@v2
with:
Expand Down
3 changes: 0 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,3 @@ require:

AllCops:
NewCops: enable
Exclude:
- '_site/**/*'

1 change: 1 addition & 0 deletions .ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.3.0
3 changes: 2 additions & 1 deletion _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,5 @@ exclude:
- "vendor"
- "README.md"
- "CONTRIBUTING.md"
- "LICENSE"
- "LICENSE"
- "spec"
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
options.add_argument('--disable-dev-shm-usage')
options.add_argument('--window-size=1400,1400')

Capybara::Selenium::Driver.new(app, browser: :chrome, options: options)
Capybara::Selenium::Driver.new(app, browser: :chrome, options:)
end

# Change default_driver to :selenium_chrome if you want to actually see the tests running in a browser locally.
Expand Down

0 comments on commit 50ed272

Please sign in to comment.