fix: base64url react native #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
force-pushed
the
fix/base64-url-react-native
branch
from
447a072
to
967f26e
Compare
berendsliedrecht
approved these changes
Jan 26, 2024
| } | ||
| } | ||
|
|
||
| export function base64ToBase64URL(base64: string) { |
There was a problem hiding this comment.
Biggest nit ever. The function does not have to be exported :). Should be the absolute slightest reduction in codegen :').
There was a problem hiding this comment.
Fixed within the GitHub Mobile app 😎
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
fix/base64-url-react-native
branch
from
ffd68da
to
321abcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bufferimplementation from Node.JS is used by default when running in Node.JS even when thebufferpackage is installed.Apparently the
bufferpackage from NPM does not supportbase64url. I've adjusted the implementation based on the implementation in AFJ