-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup and @sd-jwt/present package #31
cleanup and @sd-jwt/present package #31
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
What do you think about the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! :)
const hashResult = hasher(this.encoded) | ||
const digestResult = disclosureCalculateDigest( | ||
this.asJson(), | ||
// TODO: string vs HasherAlgorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate in this comment or link to an issue? Not too sure what we should fix here.
@@ -0,0 +1,97 @@ | |||
# Selective Disclosure JWT (SD-JWT) Draft 06 & Selective Disclosure JWT VC 01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just link in the package.json to ../../README.md
right?
I would like to have individual README's in the future though.
Yes probably more future proof. Will change it. But I think /present is already published now right? |
Ah yes. Let's just leave it as-is for now :). |
Cleans up the core package a bit by moving some things to the subpackages as well as removing duplicate code
It also adds a new
@sd-jwt/present
package which can be used to get the required disclosures based on a presentation frameThis way
@sphereon/ssi-types
only has to depend on@sd-jwt/decode
and@sphereon/pex
has to depend on@sd-jwt/core
and@sd-jwt/present
. While users of this library can still use@sd-jwt/core
Fixes #30