Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

refactor(gas): Restructure gas consumption #1117

Merged
merged 9 commits into from
Sep 20, 2023
Merged

refactor(gas): Restructure gas consumption #1117

merged 9 commits into from
Sep 20, 2023

Conversation

itsdevbear
Copy link

@itsdevbear itsdevbear commented Sep 19, 2023

attempt at fixing potential gas issues in consensus: cosmos/cosmos-sdk#12583

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1117 (fb4a543) into main (e9c1512) will increase coverage by 0.11%.
The diff coverage is 52.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   54.69%   54.80%   +0.11%     
==========================================
  Files         101      101              
  Lines        5289     5282       -7     
==========================================
+ Hits         2893     2895       +2     
+ Misses       2223     2216       -7     
+ Partials      173      171       -2     
Files Changed Coverage Δ
cosmos/x/evm/keeper/msg_server.go 0.00% <0.00%> (ø)
cosmos/x/evm/keeper/processor.go 60.60% <54.54%> (-0.11%) ⬇️
cosmos/x/evm/plugins/gas/plugin.go 74.41% <100.00%> (+0.60%) ⬆️
eth/core/processor.go 81.90% <100.00%> (+4.71%) ⬆️

Copy link
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log the error case then lgtm

@itsdevbear itsdevbear merged commit a6b99f6 into main Sep 20, 2023
@itsdevbear itsdevbear deleted the gas-like-geth branch September 20, 2023 15:09
@taeguk
Copy link
Contributor

taeguk commented Dec 13, 2023

@itsdevbear @calbera you guys saw consensus failure (like cosmos/cosmos-sdk#12583) and fixed it? Or just fixed it because you guys thought it could incur potential problems even though there was no actual problem but?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants