This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 359
refactor(gas): Restructure gas consumption #1117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocnc
approved these changes
Sep 19, 2023
Signed-off-by: Devon Bear <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
+ Coverage 54.69% 54.80% +0.11%
==========================================
Files 101 101
Lines 5289 5282 -7
==========================================
+ Hits 2893 2895 +2
+ Misses 2223 2216 -7
+ Partials 173 171 -2
|
calbera
reviewed
Sep 20, 2023
calbera
reviewed
Sep 20, 2023
calbera
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log the error case then lgtm
@itsdevbear @calbera you guys saw consensus failure (like cosmos/cosmos-sdk#12583) and fixed it? Or just fixed it because you guys thought it could incur potential problems even though there was no actual problem but? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt at fixing potential gas issues in consensus: cosmos/cosmos-sdk#12583