This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
refs #56 slackbot バージョンアップ #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.conversations API 群が使えないため)
fumi232323
commented
Sep 8, 2020
| @@ -149,7 +149,7 @@ $ (cd beproudbot/deployment && ~/venv_ansible/bin/ansible-playbook -i hosts --co | |||
|
|
|||
| - `$water count`: 現在の残数を返す | |||
| - `$water num`: 水を取り替えた時に使用。指定した数だけ残数を減らす(numが負数の場合、増やす) | |||
| - `$water hitsory <num>`: 指定した件数分の履歴を返す(default=10) | |||
| - `$water history <num>`: 指定した件数分の履歴を返す(default=10) | |||
fumi232323
commented
Sep 8, 2020
Comment on lines
+17
to
+18
| slackbot==1.0.0 | ||
| slacker==0.14.0 |
There was a problem hiding this comment.
[変更]
廃止予定のAPI channels と groups の代わりに新しいほうのAPI conversations を使えるようにするため、バージョンアップしました
[参考]
https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api
fumi232323
commented
Sep 8, 2020
|
|
||
| @respond_to('^random$') | ||
| @respond_to('^random\s+(active|help)$') | ||
| def random_command(message, subcommand=None): | ||
| """ | ||
| チャンネルにいるメンバーからランダムに一人を選んで返す | ||
| - https://github.com/os/slacker | ||
| - https://api.slack.com/methods/channels.info | ||
| - https://api.slack.com/methods/conversations.members |
There was a problem hiding this comment.
[変更]
channels.info => conversations.members に変更
[参考]
fumi232323
commented
Sep 8, 2020
| @@ -33,16 +36,11 @@ def random_command(message, subcommand=None): | |||
| channel = message.body['channel'] | |||
| webapi = slacker.Slacker(settings.API_TOKEN) | |||
| try: | |||
| cinfo = webapi.channels.info(channel) | |||
| members = cinfo.body['channel']['members'] | |||
| cinfo = webapi.conversations.members(channel) | |||
There was a problem hiding this comment.
conversations.info だと、メンバー情報は取得できないため、 conversations. members を使用します
[参考]
fumi232323
commented
Sep 8, 2020
| except slacker.Error: | ||
| try: | ||
| cinfo = webapi.groups.info(channel) | ||
| members = cinfo.body['group']['members'] |
There was a problem hiding this comment.
conversations.members で private チャンネルのメンバーも取得できるので、こちらのくだりは削除
conversations.membersは public, private, shared チャンネルのメンバーが取得できる。- 動作確認済み
fumi232323
commented
Sep 8, 2020
| # TODO: 例外で判定しないように修正する | ||
| # チャンネルに紐付かない場合はreturn | ||
| return | ||
| logger.exception('An error occurred while fetching members: channel=%s', channel) |
There was a problem hiding this comment.
エラー発生時は、ログを出力するようにしました。
fumi232323
commented
Sep 9, 2020
| @@ -6,16 +6,16 @@ geopy==1.11.0 | |||
| idna==2.6 | |||
| kml2geojson==4.0.2 | |||
| Mako==1.0.7 | |||
| MarkupSafe==1.0 | |||
| MarkupSafe==1.1.1 | |||
There was a problem hiding this comment.
[変更]
CI で、pallets/markupsafe#116 と同事象が発生したため、バージョンアップしました。 (最新の 1.1.1であれば発生しない)
- (wan さんが教えてくれたとおり)このライブラリは、alembic -> maco -> markupsafe という依存関係がある
- => alembic はマイグレーションに使用しているので、ローカル環境でバージョンアップしてマイグレーションの動作確認をした
- => 問題なかったです
fumi232323
changed the title
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットURL
このレビューで確認してほしい点
ライブラリのバージョンアップの指定が適切であること (slackbot, slacker)
ライブラリバージョンアップに伴うコードの変更 (random コマンド) が適切であること
#bot-test-fumi23p-bot-test-fumi23#s-bot-test-fumi23レビューチェックリスト