Skip to content

Commit

Permalink
Add force flag to server redirects config
Browse files Browse the repository at this point in the history
  • Loading branch information
bep committed Oct 5, 2020
1 parent ee090c0 commit e43d014
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 11 deletions.
35 changes: 26 additions & 9 deletions commands/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -378,15 +378,33 @@ func (f *fileServer) createEndpoint(i int) (*http.ServeMux, string, string, erro
if redirect := f.c.serverConfig.MatchRedirect(requestURI); !redirect.IsZero() {
// This matches Netlify's behaviour and is needed for SPA behaviour.
// See https://docs.netlify.com/routing/redirects/rewrites-proxies/
if redirect.Status == 200 {
if r2 := f.rewriteRequest(r, strings.TrimPrefix(redirect.To, u.Path)); r2 != nil {
requestURI = redirect.To
r = r2
if !redirect.Force {
path := filepath.Clean(strings.TrimPrefix(requestURI, u.Path))
fi, err := f.c.hugo().BaseFs.PublishFs.Stat(path)
if err == nil {
if fi.IsDir() {
// There will be overlapping directories, so we
// need to check for a file.
_, err = f.c.hugo().BaseFs.PublishFs.Stat(filepath.Join(path, "index.html"))
doRedirect = err != nil
} else {
doRedirect = false
}

}
}

if doRedirect {
if redirect.Status == 200 {
if r2 := f.rewriteRequest(r, strings.TrimPrefix(redirect.To, u.Path)); r2 != nil {
requestURI = redirect.To
r = r2
}
} else {
w.Header().Set("Content-Type", "")
http.Redirect(w, r, redirect.To, redirect.Status)
return
}
} else {
w.Header().Set("Content-Type", "")
http.Redirect(w, r, redirect.To, redirect.Status)
return
}

}
Expand Down Expand Up @@ -416,7 +434,6 @@ func (f *fileServer) createEndpoint(i int) (*http.ServeMux, string, string, erro

fileserver := decorate(http.FileServer(fs))
mu := http.NewServeMux()

if u.Path == "" || u.Path == "/" {
mu.Handle("/", fileserver)
} else {
Expand Down
1 change: 1 addition & 0 deletions config/commonConfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ type Redirect struct {
From string
To string
Status int
Force bool
}

func (r Redirect) IsZero() bool {
Expand Down
4 changes: 2 additions & 2 deletions docs/content/en/getting-started/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -360,10 +360,10 @@ Note that a `status` code of 200 will trigger a [URL rewrite](https://docs.netli
from = "/myspa/**"
to = "/myspa/"
status = 200
force = false
{{< /code-toggle >}}



{{< new-in "0.76.0" >}} Setting `force=true` will make a redirect even if there is existing content in the path. Note that before Hugo 0.76 `force` was the default behaviour, but this is inline with how Netlify does it.

## Configure Title Case

Expand Down

0 comments on commit e43d014

Please sign in to comment.