Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: store the cloud context into the container instead of passing it around #4907

Merged
merged 3 commits into from
Aug 8, 2024
Merged

refactor: store the cloud context into the container instead of passing it around #4907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb24746
refactor: store the cloud context into the container instead of passi…
frostming Aug 8, 2024
04a0ede
fix: deployment unittest
frostming Aug 8, 2024
88758bf
fix typing
frostming Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/_bentoml_sdk/service/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ class ResourceSchema(TypedDict, total=False):
'2' -> 2 cores
"""

cpu: str | Posint | Posfloat
cpu: Union[str, Posint, Posfloat]
"""
memory: str | Posint | Posfloat
memory: Union[str, Posint, Posfloat]
Memory resource requirement.
If int or float: Value is interpreted as number of Gibibytes (Gi).
If str: You can include unit (e.g., '512Mi', '2Gi', '1').
Expand All @@ -55,7 +55,7 @@ class ResourceSchema(TypedDict, total=False):
'512Mi' -> 512 Mebibytes
'2Gi' -> 2 Gibibytes
"""
memory: str | Posint | Posfloat
memory: Union[str, Posint, Posfloat]
gpu: Posfloat
"""
gpu type defined here is only a annotation, it will use as an recommendation choice of instance type when deploying this service to bentocloud
Expand Down
4 changes: 0 additions & 4 deletions src/bentoml/_internal/cloud/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ def push_model(
*,
force: bool = False,
threads: int = 10,
context: str | None = None,
):
pass

Expand All @@ -177,7 +176,6 @@ def push_bento(
*,
force: bool = False,
threads: int = 10,
context: str | None = None,
):
pass

Expand All @@ -187,7 +185,6 @@ def pull_model(
tag: str | Tag,
*,
force: bool = False,
context: str | None = None,
model_store: ModelStore,
) -> Model:
pass
Expand All @@ -198,7 +195,6 @@ def pull_bento(
tag: str | Tag,
*,
force: bool = False,
context: str | None = None,
bento_store: BentoStore,
) -> Bento:
pass
Loading
Loading