Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pandas): Annotated[pd.DataFrame, DataframeSchema(columns=["a"])] output spec #4799

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Jun 13, 2024

What does this PR address?

Output specs defined as Annotated[pd.DataFrame, DataframeSchema(columns=["a"])] don't work because lists are not hashable. This PR adds a converted to the columns field of DataframeSchema to convert them to a tuple.

Also adds another missing test!

Before submitting:

@judahrand judahrand requested a review from a team as a code owner June 13, 2024 13:08
@judahrand judahrand requested review from ssheng and removed request for a team June 13, 2024 13:08
@judahrand judahrand force-pushed the fix-pandas-typing branch from 6277d71 to 915c094 Compare June 13, 2024 13:10
@judahrand judahrand changed the title fix(pandas): Annotated[pd.DataFrame, DataframeSchema()] output spec fix(pandas): Annotated[pd.DataFrame, DataframeSchema(columns=["a"])] output spec Jun 13, 2024
@frostming frostming merged commit 34fb9b4 into bentoml:main Jun 14, 2024
40 of 42 checks passed
@frostming
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants