Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap tooltip to hide #69

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Tap tooltip to hide #69

merged 2 commits into from
Sep 4, 2023

Conversation

ingridwang
Copy link

@ingridwang ingridwang commented Aug 31, 2023 •
edited
Loading

Addressing #68

bensonarafat
bensonarafat reviewed Sep 3, 2023
View reviewed changes
Copy link
Owner

@bensonarafat bensonarafat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a review.
Pls can you work on that before i merge
Thanks

lib/src/super_tooltip.dart
@@ -43,7 +43,7 @@ class SuperTooltip extends StatefulWidget {
final double borderWidth;
final bool? showBarrier;
final Color? barrierColor;
final Rect? touchThrougArea;
final Rect? touchThroughArea;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

lib/src/super_tooltip.dart Show resolved Hide resolved
bensonarafat
bensonarafat approved these changes Sep 4, 2023
View reviewed changes
lib/src/super_tooltip.dart
@@ -107,6 +108,7 @@ class SuperTooltip extends StatefulWidget {
this.borderRadius = 10.0,
this.overlayDimensions = const EdgeInsets.all(10),
this.bubbleDimensions = const EdgeInsets.all(10),
this.hideTooltipOnTap = false,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad.
thanks

@bensonarafat bensonarafat merged commit 83b936c into bensonarafat:master Sep 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensonarafat bensonarafat bensonarafat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingridwang @bensonarafat