Add migration generator #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thedanbob this looks great! Thank you 🙌 I will merge this in and create a new Issue to add a test--it'll get hairy because it touches the filesystem and I don't want that to block the straightforward improvement. |
|
You're welcome! 🎉 In case it's helpful, I lifted some of this from delayed_job and maybe what they do for testing could be useful for this project too: https://github.com/collectiveidea/delayed_job_active_record/blob/master/spec/helper.rb#L55-L72 Doesn't directly apply to #57 but it would keep the schema for other tests in sync with the migration template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6.
Thanks for this project by the way, for background jobs I usually reach for sidekiq but I'm trying this out in an application where sidekiq would be major overkill.