Don’t attempt to enforce concurrency limits with other queue adapters #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed this causes a bunch of test failures so I’ll have to look into getting those passing tomorrow! |
bensheldon
reviewed
Aug 18, 2021
|
Released in Thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One other minor issue I came across with the concurrency extension is that it is always being applied regardless of which queue adapter is actually handling the job. This became a problem when I got around to testing because in our particular test suite we’re using
ActiveJob::QueueAdapters::TestAdapter. In this case jobs don’t end up being performed because there are no associatedGoodJob::Jobrows with advisory locks. This change skips enforcing the concurrency limits unless the job is being handled by the GoodJob adapter.