Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dashboard to Bootstrap 5 #260

Merged
merged 1 commit into from
May 24, 2021
Merged

Update Dashboard to Bootstrap 5 #260

merged 1 commit into from
May 24, 2021
+12 −11,926

Conversation

morgoth
Copy link
Collaborator

@morgoth morgoth commented May 18, 2021 •
edited
Loading

Looks like for current functionality, there is no need for js at all.
It can be added when such need will arrive.

Closes #258

@bensheldon
Copy link
Owner

@morgoth I fixed the Gemfile issue on the main branch (#261). If you rebase against main I think this will pass.

@morgoth
Update to bootstrap 5.
5cd3c52 
Looks like for current needs, there is no need for js at all.
It can be added when such need will arrive.
@morgoth
Copy link
Collaborator Author

morgoth commented May 24, 2021

@bensheldon it helped. Thanks

@bensheldon bensheldon changed the title Update to bootstrap 5. Update Dashboard to Bootstrap 5 May 24, 2021
bensheldon
bensheldon approved these changes May 24, 2021
View reviewed changes
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@bensheldon bensheldon merged commit 9978635 into bensheldon:main May 24, 2021
@bensheldon
Copy link
Owner

@morgoth this is released in v1.9.5

@bensheldon bensheldon added the enhancement New feature or request label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensheldon bensheldon bensheldon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update from bootstrap 4 to bootstrap 5
2 participants
@morgoth @bensheldon