Fix dashboard jobs endless pagination with timezone handling #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
reviewed
May 14, 2021
There was a problem hiding this comment.
@morgoth I'm so glad you caught this! I requested a change about where the type coercion happens. Let me know if you have thoughts about that.
lib/good_job/job.rb
Outdated
| @@ -126,6 +126,8 @@ def self.queue_parser(string) | |||
| # @return [ActiveRecord::Relation] | |||
| scope :display_all, (lambda do |after_scheduled_at: nil, after_id: nil| | |||
| query = order(Arel.sql('COALESCE(scheduled_at, created_at) DESC, id DESC')) | |||
| after_scheduled_at = Time.zone.parse(after_scheduled_at) if after_scheduled_at.present? | |||
There was a problem hiding this comment.
This will fail if after_scheduled_at is a Time or DateTime. My preference would be that type coercion happens in the controller (close to where it's coming in as a string), and models operate off of higher level objects (like Time/DateTime) rather than primitives (like Strings)
|
@morgoth Also, I apologize that there are some flakes in the Java Test Suite right now. I'm just re-running checks if they have an isolated failure and hopefully building up an understanding of where the flake is. |
Having `config.time_zone = "Europe/Berlin"` in the app, to properly handle time zone, we need to parse timestamp.
The difference before the patch:
```
irb(main):033:0> GoodJob::Job.display_all(after_scheduled_at: '2021-04-21 10:36:12 +0200').count
(1.3ms) SELECT COUNT(*) FROM "good_jobs" WHERE ((COALESCE(scheduled_at, created_at)) < ('2021-04-21 10:36:12 +0200'))
=> 1
irb(main):034:0> GoodJob::Job.display_all(after_scheduled_at: Time.zone.parse('2021-04-21 10:36:12 +0200')).count
(1.2ms) SELECT COUNT(*) FROM "good_jobs" WHERE ((COALESCE(scheduled_at, created_at)) < ('2021-04-21 08:36:12'))
=> 0
```
bensheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
config.time_zone = "Europe/Berlin"in the app, to properly handle time zone, we need to parse timestamp.The difference before the patch: