Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appraisal and bundler version CI conflicts #224

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Mar 5, 2021

Fixes problem by pinning thoughtbot/appraisal#174

Also took opportunity to simplify the Github Actions:

  • Fully use ruby/setup-ruby action's bundler version and gem caching
  • Simplify the ruby/pg matrix
  • libpg-dev has been added to the base image: Add libpq-dev actions/runner-images#12 and the line about "Install missing libs" can be removed.

Response to seeing errors like:

  •  Run bundle exec appraisal install --without lint --path $BUNDLE_PATH
     bundler: failed to load command: appraisal (/home/runner/work/good_job/good_job/vendor/bundle/ruby/2.7.0/bin/appraisal)
     /opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/site_ruby/2.7.0/bundler/runtime.rb:302:in `check_for_activated_spec!': You have already activated bundler 2.2.11, but your Gemfile requires bundler 2.2.13. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError)
    
  • Trying to register Bundler::GemfileError for status code 4 but Bundler::GemfileError is already registered

@bensheldon bensheldon force-pushed the cleanup_bundler branch 12 times, most recently from 985ed6b to fea8131 Compare March 12, 2021 03:03
@bensheldon bensheldon changed the title Remove other versions of bundler for CI Fix appraisal and bundler version CI conflicts Mar 12, 2021
@bensheldon bensheldon force-pushed the cleanup_bundler branch 2 times, most recently from 7af7626 to 7bf7525 Compare March 12, 2021 15:50
@bensheldon bensheldon merged commit ca8526c into main Mar 12, 2021
@bensheldon bensheldon deleted the cleanup_bundler branch March 12, 2021 16:23
@bensheldon bensheldon added the dependencies Pull requests that update a dependency file label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant