Do not add lib/generators to Zeitwerk autoloader #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
require_install
branch
from
8bda540 to
5cf579b
Compare
bensheldon
force-pushed
the
require_install
branch
from
5cf579b to
9918017
Compare
bensheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think (and experimentally believe) that the
rails generatorcommand does an implicit lookup and the generator does not have to be explicitly loaded.Many other gems appear to explicitly ignore
lib/generatorstoo: https://github.com/search?l=Ruby&q=Zeitwerk%3A%3ALoader.for_gem+generators&type=CodeAddresses this issue of the Zeitwerk autoloader complaining that it expects
lib/generators/good_job/templatesto contain a matching class. #160 (comment)