Ensure advisory lock CTE is MATERIALIZED on Postgres v12+ #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
postgres_matrix
branch
from
0b193d7 to
a5bab0c
Compare
bensheldon
force-pushed
the
postgres_matrix
branch
from
a5bab0c to
e97c23d
Compare
bensheldon
changed the title
bensheldon
changed the title
bensheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advisory lock strategy uses a nested CTE that relies on the CTE being materialized to prevent the higher-level
pg_try_advisory_lockcondition from being pushed down.Before Postgres 12, the materialized CTE was implicit; Postgres 12+ makes materialization explicit and disabled by default.
Connects to #177