UI: Admin UI with filters and space efficient layout #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgoth
reviewed
Nov 22, 2020
zealot128
force-pushed
the
main
branch
2 times, most recently
from
92fc956 to
eb9ae83
Compare
bensheldon
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
@zealot128 Thank you for the contribution. This is a very nice improvement.
I have two suggestions, but I'm willing to merge this as is and accept the improvements as later PRs:
- I think the filters should always be visible, even if there are no jobs. Currently they disappear if a filter is selected that results in no jobs.
- When a filter is selected, the link button should be in an active state with
activeclass
@bensheldon Good suggestions! I've updated the branch. It now looks like this:
|
|
@zealot128 Thank you so much! I just released this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to see a basic admin layout! Some changes I might propose
container-fluidinstead of container - Very useful for larger tables..., table-sm to preserve whitespace for a more space efficient tableNot sure where to put the filter ruby class from the code perspective.