Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Scheduler polling behavior to its own object #152

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Extract Scheduler polling behavior to its own object #152

merged 1 commit into from
Oct 3, 2020

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Sep 23, 2020 •
edited
Loading

Closes #128

bensheldon
bensheldon commented Sep 23, 2020
View reviewed changes
lib/good_job/poller.rb Outdated Show resolved Hide resolved
bensheldon
bensheldon commented Oct 3, 2020
View reviewed changes
lib/good_job/poller.rb Outdated Show resolved Hide resolved
@bensheldon bensheldon mentioned this pull request Oct 3, 2020
Closed
@bensheldon bensheldon merged commit 70456f5 into main Oct 3, 2020
@bensheldon bensheldon deleted the create-poller branch October 3, 2020 23:19
@bensheldon bensheldon added enhancement New feature or request refactor Code changes that do not introduce new features and removed enhancement New feature or request labels Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Code changes that do not introduce new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract polling from scheduler into Polling object
1 participant
@bensheldon