Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually bump tapioca / regenerate rbi #1514

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Earlopain
Copy link
Collaborator

Dependabot does not do this because it resolves with Ruby 3.0 from the gemspec and tapioca now only supports 3.1

This unblocks prism 1.0 which is required for the ruby-lsp to update to the latest version. Currently it runs into Shopify/ruby-lsp#2630, causing a restart loop.

To make sure this does the right thing on older rubies, I added a step to print the resolved lockfile on CI

Dependabot does not do this because it resolves with Ruby 3.0 from the gemspec
and tapioca now only supports 3.1

This unblocks prism 1.0 which is required for the ruby-lsp to update to the latest version.
Currently it runs into Shopify/ruby-lsp#2630, causing a restart loop.

To make sure this does the right thing on older rubies, I added a step to print the resolved lockfile on CI
@bensheldon
Copy link
Owner

Thanks for noticing that!

@bensheldon bensheldon merged commit ca811f0 into bensheldon:main Oct 10, 2024
25 checks passed
@Earlopain Earlopain deleted the bump-tapioca branch October 10, 2024 20:43
@Earlopain
Copy link
Collaborator Author

It was quite hard not to, the persistent notifications from my IDE about this were quite noticable. I think this dependabot issue is about cases like this: dependabot/dependabot-core#4987, though the situation is a bit different with the lockfile being used for both library and application (the demo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants