Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cron_graceful_restart_period to avoid missing recurring jobs that occurred during deployment downtime #1488

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

bensheldon
Copy link
Owner

Closes #1484

@Earlopain
Copy link
Collaborator

Earlopain commented Sep 18, 2024

If I use this in conjunction with preserve_job_records = false then this will double-enqueue, right? I'm not sure how this behaves even right now, I guess it probably works (as long as process clocks are close enough)?

@bensheldon
Copy link
Owner Author

Good question! Cron'ed jobs will ignore the preserve_job_records configuration and always be preserved (until they're automatically cleaned up): #767

@Earlopain
Copy link
Collaborator

Ah right, good to know 👍. I was looking at that piece of code by searching for preserve_job_records but missed the relevant condition to the right

@tjefferson08
Copy link

very cool, thanks for this feature 👍 all your heroku users thank you!

@bensheldon bensheldon merged commit 54087be into main Oct 8, 2024
10 checks passed
@bensheldon bensheldon deleted the cron-graceful-restart-period branch October 8, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Cron jobs can be missed if deploys are timed just right
3 participants