Use rails enum for error_event and lock_type
#1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
rails-enum
branch
2 times, most recently
from
5afd568
to
66e2fbb
Compare
In older versions it should raise an ArgumentError right? I'm sorta mixed on whether removing the constants in favor of strings+validations is equivalent in protection against fat fingering it, but it's probably ok 👍🏻 |
|
Yeah, that's right. You would get an ArgumentError on 6.1 at assign time (i.e. |
Earlopain
added a commit
to Earlopain/good_job
that referenced
this pull request
Aug 6, 2024
2 enum values conflict with already existing scopes: "retried" and "discarded" (bensheldon#1420) "running" and "finished" got moved from the discrete execution (bensheldon#1427)
bensheldon
added a commit
that referenced
this pull request
Aug 8, 2024
* Fix a few method redefinition warnings 2 enum values conflict with already existing scopes: "retried" and "discarded" (#1420) "running" and "finished" got moved from the discrete execution (#1427) * Use the simpler version of finished; use queued/running without checking advisory locks --------- Co-authored-by: Ben Sheldon [he/him] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit more cleanup now that v4 is released.
Rails 7.2 will deprecate the legacy enum notation but the new one was only introduced in Rails 7.0 so a bit of version introspection is needed here.
I also had to notice that proper validations are only available in rails 7.1. I think that's fine, the test matrix will take care of this but its not as nice as I expected it would be.
There was a duplicate
table_nameinprocess.rb, I've removed that in the process of this.