Better table name detection for Job queries

[gadimbaylisahil]

#117

[gadimbaylisahil]

@bensheldon There are two commits here. First one just removes the .public from the table name and is a hacky way to display the working version.

The second commit tries to include the table_name in

      scope :joins_advisory_locks, (lambda do
        join_sql = <<~SQL
          LEFT JOIN pg_locks ON pg_locks.locktype = 'advisory'
            AND pg_locks.objsubid = 1
            AND pg_locks.classid = ('x'||substr(md5(:table_name || :table_with_primary_key_quoted::text), 1, 16))::bit(32)::int
            AND pg_locks.objid = (('x'||substr(md5(:table_name || :table_with_primary_key_quoted::text), 1, 16))::bit(64) << 32)::bit(32)::int
        SQL

        table_with_primary_key_quoted = [quoted_table_name, quoted_primary_key].join('.')

        joins(sanitize_sql([join_sql, { table_name: quoted_table_name, table_with_primary_key_quoted: table_with_primary_key_quoted }]))
      end)

with table_with_primary_key_quoted = [quoted_table_name, quoted_primary_key].join('.'). However this produces different SQL string after sanitization with wrapped up in single quotes.

Prior does as "good_jobs"."id" but the latter is '"public"."good_jobs"."id"'::text. This results in empty collection.

If I were to put the "public"."good_jobs"."id" manually without the single quotes that sanitization produces, all works fine.

I assume this is due to md5 generation which includes single quotes in the latter version which then doesn't matchup with other quries/locks(not sure).

[bensheldon]

Oops, I think you have the parameters/interpolation behavior reversed. Please see my comment.

[bensheldon]

I think you have the logic reversed on these.

The parameterized value does not need to be quoted because it is intended to be inserted into the query as a parameterized string.

The interpolated table/columns are the ones that need to be quoted. (Sorry, I'm on my phone so I can't write out code easily).

Eg

.where(Arel.sql(sanitize_sql_for_conditions(["pg_try_advisory_lock(('x'||substr(md5(:table_name || #{quoted_table_name(cte_table.name)}.#{quoted_column_name(primary_key)}::text), 1, 16))::bit(64)::bigint)", { table_name: table_name }])))

[gadimbaylisahil]

I reverted this change as it was unrelated. But than you for mentioning the quotation thing. I removed extra quotations now. The only change I made is in joins_advisory_lock scope which adds quoted_table_name and quoted_primary_key which fixes the issue.

However, I am curious of any side-effects it may produce/or not.

[gadimbaylisahil]

Closes #117

[bensheldon]

👍 thank you!

[bensheldon]

@gadimbaylisahil I just released GoodJob v1.2.4 with this change.