Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop depending on all rails libs #104

Merged
merged 2 commits into from
Aug 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 3 additions & 60 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,44 +2,23 @@ PATH
remote: .
specs:
good_job (1.2.2)
activejob (>= 5.1.0)
activerecord (>= 5.1.0)
concurrent-ruby (>= 1.0.2)
pg (>= 1.0.0)
rails (>= 5.1.0)
railties (>= 5.1.0)
thor (>= 0.14.1)

GEM
remote: https://rubygems.org/
specs:
actioncable (6.0.3.2)
actionpack (= 6.0.3.2)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
actionmailbox (6.0.3.2)
actionpack (= 6.0.3.2)
activejob (= 6.0.3.2)
activerecord (= 6.0.3.2)
activestorage (= 6.0.3.2)
activesupport (= 6.0.3.2)
mail (>= 2.7.1)
actionmailer (6.0.3.2)
actionpack (= 6.0.3.2)
actionview (= 6.0.3.2)
activejob (= 6.0.3.2)
mail (~> 2.5, >= 2.5.4)
rails-dom-testing (~> 2.0)
actionpack (6.0.3.2)
actionview (= 6.0.3.2)
activesupport (= 6.0.3.2)
rack (~> 2.0, >= 2.0.8)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.0)
rails-html-sanitizer (~> 1.0, >= 1.2.0)
actiontext (6.0.3.2)
actionpack (= 6.0.3.2)
activerecord (= 6.0.3.2)
activestorage (= 6.0.3.2)
activesupport (= 6.0.3.2)
nokogiri (>= 1.8.5)
actionview (6.0.3.2)
activesupport (= 6.0.3.2)
builder (~> 3.1)
Expand All @@ -54,11 +33,6 @@ GEM
activerecord (6.0.3.2)
activemodel (= 6.0.3.2)
activesupport (= 6.0.3.2)
activestorage (6.0.3.2)
actionpack (= 6.0.3.2)
activejob (= 6.0.3.2)
activerecord (= 6.0.3.2)
marcel (~> 0.3.1)
activesupport (6.0.3.2)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
Expand Down Expand Up @@ -102,13 +76,7 @@ GEM
loofah (2.6.0)
crass (~> 1.0.2)
nokogiri (>= 1.5.9)
mail (2.7.1)
mini_mime (>= 0.1.1)
marcel (0.3.3)
mimemagic (~> 0.3.2)
method_source (1.0.0)
mimemagic (0.3.5)
mini_mime (1.0.2)
mini_portile2 (2.4.0)
minitest (5.14.1)
msgpack (1.3.3)
Expand Down Expand Up @@ -136,21 +104,6 @@ GEM
rack (2.2.3)
rack-test (1.1.0)
rack (>= 1.0, < 3)
rails (6.0.3.2)
actioncable (= 6.0.3.2)
actionmailbox (= 6.0.3.2)
actionmailer (= 6.0.3.2)
actionpack (= 6.0.3.2)
actiontext (= 6.0.3.2)
actionview (= 6.0.3.2)
activejob (= 6.0.3.2)
activemodel (= 6.0.3.2)
activerecord (= 6.0.3.2)
activestorage (= 6.0.3.2)
activesupport (= 6.0.3.2)
bundler (>= 1.3.0)
railties (= 6.0.3.2)
sprockets-rails (>= 2.0.0)
rails-dom-testing (2.0.3)
activesupport (>= 4.2.0)
nokogiri (>= 1.6)
Expand Down Expand Up @@ -212,21 +165,11 @@ GEM
addressable (>= 2.3.5)
faraday (> 0.8, < 2.0)
sigdump (0.2.4)
sprockets (4.0.2)
concurrent-ruby (~> 1.0)
rack (> 1, < 3)
sprockets-rails (3.2.1)
actionpack (>= 4.0)
activesupport (>= 4.0)
sprockets (>= 3.0.0)
thor (1.0.1)
thread_safe (0.3.6)
tzinfo (1.2.7)
thread_safe (~> 0.1)
unicode-display_width (1.7.0)
websocket-driver (0.7.3)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
yard (0.9.25)
zeitwerk (2.3.1)

Expand Down
4 changes: 3 additions & 1 deletion gemfiles/rails_5.2.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ PATH
remote: ..
specs:
good_job (1.2.2)
activejob (>= 5.1.0)
activerecord (>= 5.1.0)
concurrent-ruby (>= 1.0.2)
pg (>= 1.0.0)
rails (>= 5.1.0)
railties (>= 5.1.0)
thor (>= 0.14.1)

GEM
Expand Down
4 changes: 3 additions & 1 deletion gemfiles/rails_6.0.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ PATH
remote: ..
specs:
good_job (1.2.2)
activejob (>= 5.1.0)
activerecord (>= 5.1.0)
concurrent-ruby (>= 1.0.2)
pg (>= 1.0.0)
rails (>= 5.1.0)
railties (>= 5.1.0)
thor (>= 0.14.1)

GEM
Expand Down
4 changes: 3 additions & 1 deletion good_job.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = ">= 2.4.0"

spec.add_dependency "activejob", ">= 5.1.0"
spec.add_dependency "activerecord", ">= 5.1.0"
spec.add_dependency "concurrent-ruby", ">= 1.0.2"
spec.add_dependency "pg", ">= 1.0.0"
spec.add_dependency "rails", ">= 5.1.0"
spec.add_dependency "railties", ">= 5.1.0"
spec.add_dependency "thor", ">= 0.14.1"

spec.add_development_dependency "appraisal"
Expand Down
2 changes: 1 addition & 1 deletion spec/support/example_app_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def setup_example_app
root_path = example_app_path.join('..')

FileUtils.cd(root_path) do
`rails new #{app_name} -d postgresql --skip-action-mailer --skip-action-mailbox --skip-action-cable --skip-sprockets --skip-listen --skip-javascript --skip-turbolinks --skip-system-test --skip-test-unit --skip-bootsnap --skip-spring`
`rails new #{app_name} -d postgresql --no-assets --skip-action-text --skip-action-mailer --skip-action-mailbox --skip-action-cable --skip-sprockets --skip-listen --skip-javascript --skip-turbolinks --skip-system-test --skip-test-unit --skip-bootsnap --skip-spring --skip-active-storage`
end

File.open("#{example_app_path}/Gemfile", 'a') do |f|
Expand Down
2 changes: 1 addition & 1 deletion spec/test_app/config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Application < Rails::Application
# the framework and any gems in your application.
#

config.middleware.insert_before Rack::Sendfile, ActionDispatch::DebugLocks
# config.middleware.insert_before Rack::Sendfile, ActionDispatch::DebugLocks
config.log_level = :debug
end
end
Expand Down
10 changes: 5 additions & 5 deletions spec/test_app/config/environments/development.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
end

# Store uploaded files on the local file system (see config/storage.yml for options).
config.active_storage.service = :local
# config.active_storage.service = :local

# Don't care if the mailer can't send.
config.action_mailer.raise_delivery_errors = false
# config.action_mailer.raise_delivery_errors = false

config.action_mailer.perform_caching = false
# config.action_mailer.perform_caching = false

# Print deprecation notices to the Rails logger.
config.active_support.deprecation = :log
Expand All @@ -48,10 +48,10 @@
# Debug mode disables concatenation and preprocessing of assets.
# This option may cause significant delays in view rendering with a large
# number of complex assets.
config.assets.debug = true
# config.assets.debug = true

# Suppress logger output for asset requests.
config.assets.quiet = true
# config.assets.quiet = true

# Raises error for missing translations.
# config.action_view.raise_on_missing_translations = true
Expand Down
6 changes: 3 additions & 3 deletions spec/test_app/config/environments/production.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
# config.assets.css_compressor = :sass

# Do not fallback to assets pipeline if a precompiled asset is missed.
config.assets.compile = false
# config.assets.compile = false

# Enable serving of images, stylesheets, and JavaScripts from an asset server.
# config.action_controller.asset_host = 'http://assets.example.com'
Expand All @@ -36,7 +36,7 @@
# config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX

# Store uploaded files on the local file system (see config/storage.yml for options).
config.active_storage.service = :local
# config.active_storage.service = :local

# Mount Action Cable outside main process or domain.
# config.action_cable.mount_path = nil
Expand All @@ -60,7 +60,7 @@
# config.active_job.queue_adapter = :resque
# config.active_job.queue_name_prefix = "test_app_production"

config.action_mailer.perform_caching = false
# config.action_mailer.perform_caching = false

# Ignore bad email addresses and do not raise email delivery errors.
# Set this to true and configure the email server for immediate delivery to raise delivery errors.
Expand Down
2 changes: 1 addition & 1 deletion spec/test_app/config/initializers/assets.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Be sure to restart your server when you modify this file.

# Version of your assets, change this if you want to expire all your assets.
Rails.application.config.assets.version = '1.0'
# Rails.application.config.assets.version = '1.0'

# Add additional assets to the asset load path.
# Rails.application.config.assets.paths << Emoji.images_path
Expand Down