Merge pull request #148 from bensheldon/notification_names

Fix LogSubscriber notifications for finished_timer_task and finished_job_task
bensheldon · Sep 21, 2020 · f57209e · f57209e
2 parents 3bde4a0 + 9446165
commit f57209e
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/good_job/log_subscriber.rb b/lib/good_job/log_subscriber.rb
@@ -25,8 +25,7 @@ def create(event)
     end
 
     # @macro notification_responder
-    def timer_task_finished(event)
-      # FIXME: This method does not match any good_job notifications.
+    def finished_timer_task(event)
       exception = event.payload[:error]
       return unless exception
 
@@ -36,8 +35,7 @@ def timer_task_finished(event)
     end
 
     # @macro notification_responder
-    def job_finished(event)
-      # FIXME: This method does not match any good_job notifications.
+    def finished_job_task(event)
       exception = event.payload[:error]
       return unless exception