Add Ruby 3 to CI test matrix

bensheldon · Dec 28, 2020 · 2cf676c · 2cf676c
1 parent 0557881
commit 2cf676c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -52,7 +52,7 @@ jobs:
     timeout-minutes: 15
     strategy:
       matrix:
-        ruby: [2.5, 2.6, 2.7]
+        ruby: [2.5, 2.6, 2.7, 3.0]
         pg: [12.5, 10.8]
     env:
       PGHOST: localhost
@@ -110,3 +110,9 @@ jobs:
         with:
           name: screenshots
           path: spec/test_app/tmp/screenshots
+      - name: Archive Rails logs
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: rails_logs
+          path: spec/test_app/log
diff --git a/Appraisals b/Appraisals
@@ -1,5 +1,7 @@
-appraise "rails-5.2" do
-  gem "rails", "~> 5.2.0"
+if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3')
+  appraise "rails-5.2" do
+    gem "rails", "~> 5.2.0"
+  end
 end
 
 appraise "rails-6.0" do

diff --git a/spec/lib/good_job/cli_spec.rb b/spec/lib/good_job/cli_spec.rb
@@ -13,7 +13,6 @@
 
   describe '#start' do
     it 'initializes a scheduler' do
-      allow(GoodJob::Scheduler).to receive(:new).and_call_original
       allow(Kernel).to receive(:loop)
 
       cli = described_class.new([], {}, {})