Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet lists in edit mode not compatible with different fonts #32

Closed
OscarAblinger opened this issue Jun 23, 2021 · 1 comment
Closed

Comments

@OscarAblinger
Copy link

I'm using the Obsidianite theme but wanted to change the fonts. Sadly that introduced a visual bug with the bullets.
For one the bullet was halved. And the not-focused lines would also be moved a bit to the right, making vertical movements slightly more annoying.

I understand that you don't necessarily support different fonts, so feel free to close this issue again.
However, since I fixed it in a quick CSS snippet, I figured that it might be useful to some people:

div:not(.CodeMirror-activeline) > .CodeMirror-line span.cm-formatting-list-ul {
    text-indent: inherit !important;
    white-space: inherit !important;
    min-width: inherit !important;
    visibility: hidden;
}

div:not(.CodeMirror-activeline) > .CodeMirror-line span.cm-formatting-list-ul::after {
    left: 0 !important;
    visibility: visible;
}

All of the !important styles only overwrite some of the Obsidianite CSS, so if it was integrated into the theme, you would just remove the lines that originally change those properties.
Essentially, instead of adding a dot after the text and then moving it a fixed amount to the left, I just added the dot at the start of the line on top and just made the normal text invisible.
That way it should be compatible with any font.

For reference:
With out the fix:
grafik
With the fix:
grafik
It also works with the default fonts:
grafik

@bennyxguo
Copy link
Owner

This should no longer be a problem with the live preview mode in the latest code.

bennyxguo pushed a commit that referenced this issue Oct 9, 2022
### New Diamonds 💎

- Removed all the old `Cluster Free` code (please move to `live preview` mode)
- Added support for `live preview` mode [#44]
  - Supporting all the features that is there fore for live preview

### Fixes

- Problem with code block should no longer exist with `live preview` [#52]
- Images now align to left, fixed issue with image having no spaces between list items [#50][#34]
- Fixed issue with strange block that hides top of the page in edit mode with `live preview` [#47]
- Fixed bullet point not visible in view mode [#45]
- Fixed bullet lists in edit mode not compatible with different fonts [#32]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants