Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring flow type exports #639

Merged
merged 2 commits into from
Nov 3, 2016
Merged

Ignoring flow type exports #639

merged 2 commits into from
Nov 3, 2016

Conversation

jakubsta
Copy link
Contributor

@jakubsta jakubsta commented Oct 24, 2016 •
edited
Loading

resolve #484

@jakubsta jakubsta changed the title Ignoring flow type exports, resolve #484 Ignoring flow type exports Oct 24, 2016
jfmengels
jfmengels requested changes Oct 24, 2016
View reviewed changes
Copy link
Collaborator

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jakubsta! Thanks a lot for this :)

  1. Could you add some tests to make sure this works well?
  2. Could you add a line in the changelog about this?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 94.907% when pulling cd37890 on jakubsta:feature/flow_type_exports into edbb570 on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 94.907% when pulling cd37890 on jakubsta:feature/flow_type_exports into edbb570 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 94.907% when pulling cd37890 on jakubsta:feature/flow_type_exports into edbb570 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 94.907% when pulling cd37890 on jakubsta:feature/flow_type_exports into edbb570 on benmosher:master.

@jakubsta
Copy link
Contributor Author

@jfmengels Could you have a look once again?

@coveralls
Copy link

coveralls commented Oct 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 94.907% when pulling 4c54e9e on jakubsta:feature/flow_type_exports into edbb570 on benmosher:master.

jfmengels
jfmengels approved these changes Nov 2, 2016
View reviewed changes
Copy link
Collaborator

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jakubsta ! (and sorry for the delay in reviewing this)

@benmosher benmosher mentioned this pull request Nov 2, 2016
Merged
10 tasks
@benmosher benmosher merged commit 29bc56e into import-js:master Nov 3, 2016
This was referenced Apr 15, 2018
Merged
Merged
@thisissami thisissami mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfmengels jfmengels jfmengels approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import/prefer-default-export should ignore type for flowtype
4 participants
@jakubsta @coveralls @jfmengels @benmosher