-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): use default syntax for typedef #11
Conversation
this will enable projects consuming symbol-observable from TS (eg, RxJS) to use ```typescript import $$observable from 'symbol-observable' ``` rather than ```typescript import * as $$observable from 'symbol-observable' ``` This might? require downstream changes on RxJS but its more correct methinks.
👍 I think that one's my bad.. :/ |
I don't think changing the var ponyfill = require('./ponyfill')(root);
module.exports = ponyfill;
module.exports.default = ponyfill; More info: microsoft/TypeScript#2242 (comment) |
@robwormald did you test this? Do we have tests for this? How do we test this? haha. It LGTM... I just want to be sure. |
You test it by actually using typescript and the typescript compiler and verifying you get no type warnings / errors. |
Yes... I know, I'm just travelling and I was hoping to prompt someone else into adding it. :) haha Too subtle, I guess. |
Maybe don't merge this yet, the behavior is kinda weird. I'll work through it this weekend. |
I just tested this, and it doesn't work properly in TypeScript. |
the import is |
Closing in favor of #12, which adds a test (that is currently failing) |
this will enable projects consuming symbol-observable from TS (eg, RxJS) to use
rather than
This might? require downstream changes on RxJS but its more correct methinks.