Layout is not set correctly on search

[msbentley]

I have tagged my notes, and when clicking from the notelist, this works extremely well. But when I search, the tag is not respected when the first hit in the filtered note-list is displayed. For example:

persistent-layout.mp4

Versions

• plugin version: v1.1.1
• joplin version: 1.7.11
• operating system: linux
• OS version: ubuntu 20.04

[benji300]

Thanks for your detailed error description. I can confirm the behavior. For example if you have a note selected with layout:split and then search for a note with layout:richtext specified, the layout seems not to change.

But technically it is changed... unfortunately it is changed twice in a row. So it seems it is not switched to the richtext layout. Also it seems only to be a problem if layout:richtext is involved. What I can see is, that the event onNoteSelectionChange() is triggered twice almost in parallel (I guess) when the search is executed. The following screenshot shows some debug messages I've added to the code. It is taken directly after the search was executed. There you can see that toggleEditor is triggered twice because previous check of global setting codeView results in true. Also it shows that onNoteSelectionChange is triggered twice.

I've created branch including the debug messages: https://github.com/benji300/joplin-persistent-layout/tree/search-issue-7

[msbentley]

Thanks @benji300 - do you know if this has been flagged as an issue in the Joplin github?

[ken1kob]

Thank you, @benji300, for this very nice plugin.

I analyzed this issue, fixed it and sent a pull request.
The technical detail is very complicated and is described this Joplin's issue.

[benji300]

Fixed with https://github.com/benji300/joplin-persistent-layout/releases/tag/v2.2.0