Docwhat feedback #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2017 09:47
Releases were not working because `git clean` was being on called on the repo by travis and I was unaware of that
This way a person does not need to manually verify that the release version in the code is in sync with the release tags
docwhat
reviewed
Jul 31, 2017
.gitignore
Outdated
| @@ -3,3 +3,7 @@ | |||
| vendor/github.com/ | |||
| vendor/golang.org/ | |||
| vendor/gopkg.in/ | |||
| pachelbel | |||
There was a problem hiding this comment.
leading / characters? Ditto for the /vendor as well?
Makefile
Outdated
| @@ -1,4 +1,4 @@ | |||
| CC=gcc | |||
| LDFLAGS="-X github.com/benjdewan/pachelbel/cmd.version=$(shell git describe --tags || echo DEV-BUILD)" | |||
There was a problem hiding this comment.
Do you really need the whole github.com/... part?
| @@ -26,7 +26,7 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| const version string = "v0.1.2" | |||
| var version string = "DEV-BUILD" | |||
There was a problem hiding this comment.
Shouldn't the version be in main? The CLI's version isn't that interesting, but the version of whatever it does is.
There was a problem hiding this comment.
I thought
$ pachelbel versionwas nicer than
$ pachelbel -versionAnd you can't reference the main package from cmd since that would create a cycle.
There was a problem hiding this comment.
Fair enough; I haven't read through the code yet.
* Add leading '/' characters to .gitignore paths * Shorten the import path
docwhat
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.