Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript override keyword printer #1151

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Fix typescript override keyword printer #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a46f75c
tdd
625dennis Jul 20, 2022
bc030e5
add override keyword to printMethod function
625dennis Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/printer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2741,6 +2741,10 @@ function printMethod(path: any, options: any, print: any) {
parts.push("abstract ");
}

if (node.override) {
parts.push("override ");
}

if (node.readonly) {
parts.push("readonly ");
}
Expand Down
8 changes: 8 additions & 0 deletions test/typescript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,14 @@ const nodeMajorVersion = parseInt(process.versions.node, 10);
"}",
]);

check([
"class Dog extends Animal {",
" protected override getSound() {",
" return 'bark';",
" }",
"}",
])

check(["export interface S {", " i(s: string): boolean", "}"]);

check([
Expand Down