Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't depend on esprima#harmony #105

Closed
jonathanong opened this issue Jul 29, 2014 · 9 comments · Fixed by #106
Closed

don't depend on esprima#harmony #105

jonathanong opened this issue Jul 29, 2014 · 9 comments · Fixed by #106

Comments

@jonathanong
Copy link

npm is stupid with git dependencies and downloads a copy for every module that depends on them. now my node_modules is 200mb because i have 20 copies of esprima#harmony. any chance to change the esprima dep to a semver range and expect users to install esprima#harmony themselves if they wish?

@redonkulus
Copy link

+1 we are having issues as well due to the git+https change. Could you use esprima-fb package to pull in this dependency?

@caridy
Copy link

caridy commented Aug 14, 2014

@benjamn since we are not getting any traction on esprima#harmony, should be go with esprima-fb? we should align all the tools, transpilers, etc, to use esprima-fb as well to avoid the npm issues with branches. /cc @eventualbuddha

@benjamn
Copy link
Owner

benjamn commented Aug 14, 2014

I'm not opposed to that, especially since you can always override the version of esprima used.

@eventualbuddha
Copy link
Collaborator

Seems good to me. I'm ready to make the switch once recast supports it.

@caridy
Copy link

caridy commented Aug 14, 2014

@benjamn good, we are wondering what's going on with the versions you guys are using for that pkg, and figure it you guys can follow semver some how to allow deduping in npm. /cc @jeffmo

@caridy
Copy link

caridy commented Aug 15, 2014

ok, confirmed that esprima-fb is following semver, we are good to go!

@benjamn the ball is in your court now ;)

@benjamn
Copy link
Owner

benjamn commented Aug 15, 2014

@zpao @jeffmo can you npm publish the latest version of esprima-fb?

@jeffmo
Copy link

jeffmo commented Aug 15, 2014

5001.1.0-dev-harmony-fb published

@benjamn
Copy link
Owner

benjamn commented Aug 15, 2014

Published v0.7.0 to NPM: https://www.npmjs.org/package/recast

Also did a GitHub release, for the first time ever (better now than never?): https://github.com/benjamn/recast/releases/tag/v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants