-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't depend on esprima#harmony #105
Comments
+1 we are having issues as well due to the git+https change. Could you use esprima-fb package to pull in this dependency? |
@benjamn since we are not getting any traction on |
I'm not opposed to that, especially since you can always override the version of esprima used. |
Seems good to me. I'm ready to make the switch once recast supports it. |
ok, confirmed that @benjamn the ball is in your court now ;) |
|
Published v0.7.0 to NPM: https://www.npmjs.org/package/recast Also did a GitHub release, for the first time ever (better now than never?): https://github.com/benjamn/recast/releases/tag/v0.7.0 |
npm is stupid with git dependencies and downloads a copy for every module that depends on them. now my node_modules is 200mb because i have 20 copies of esprima#harmony. any chance to change the
esprima
dep to a semver range and expect users to installesprima#harmony
themselves if they wish?The text was updated successfully, but these errors were encountered: