Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Style Module are not saved #20

Closed
dwenzel opened this issue Jun 25, 2014 · 16 comments
Closed

Changes in Style Module are not saved #20

dwenzel opened this issue Jun 25, 2014 · 16 comments

Comments

@dwenzel
Copy link

dwenzel commented Jun 25, 2014

Any change in Style Module is ignored.
Ext bootstrap_package has been installed as part of the preconfigured Introduction Package on a fresh TYPO3 6.2.3

@benjaminkott
Copy link
Owner

hey @dwenzel thx for reporting.
Does the style module save the changes? or dont they simply dont show up in the frontend?

@dwenzel
Copy link
Author

dwenzel commented Jun 27, 2014

Hi @benjaminkott, thx for caring :)
the style module doesn't save any changes.

Cheers
Dirk

Am 27.06.2014 um 18:35 schrieb Benjamin Kott:

hey @dwenzel thx for reporting.
Does the style module save the changes? or dont they simply dont show up in the frontend?


Reply to this email directly or view it on GitHub.

@timpleton
Copy link

Hi, any news in this issue?
I get the same behavior on a freshly installed TYPO3 6.2.4 with "Introduction Package". A blank install with manually added Bootstrap Package does not save the changes either.
Do you have any hints on what to check? Anything I can help with?

@benjaminkott
Copy link
Owner

@dwenzel @timpleton hey, i had a look into this issue but i really cannot reproduce this issue - tested this already on multiple environments. we are currently working on an alternative implementation to solve this issue and the hardcoded less issue with multiple installations etc. hove i can provide an update till end of next week.

but in general any help is appreciated - missing features, bugs etc just provide patches if you like.

@timpleton
Copy link

@benjaminkott Hi, I'm not deep enough into it to try patching or bugfixing myself. Which file is it, that should be written when clicking on the "Save"-Button in the style editor? Maybe it's a problem with ACL or file permissions. I want to check this...

@benjaminkott
Copy link
Owner

@timpleton when you hit the save button the script writes an new less variables file / or updates an existing one that is placed here: typo3conf\ext\bootstrap_package\Resources\Private\Less\Bootstrap-3-1-1\variables.less

@timpleton
Copy link

@benjaminkott I checked permissions on these files. They were all writeable by the webserver.
Is there anything I can do beside turning TYPO3 into debug mode and rising PHPs error logging? Because I do not see any errors in my logs when I click the save button.

benjaminkott added a commit that referenced this issue Jul 20, 2014
…to provide a more flexible less configuration - fixes #5 #20
@benjaminkott
Copy link
Owner

Hey @timpleton @dwenzel,
I removed the backendmodule - you can now place less files directly in your typoscript as you do it with normal css files. All bootstrap variables are configurable via typoscript and the less files an now rendered and cached on demand.

bootstrap_package-styling

I will close this issue since the original problem does not exist anymore.

@dwenzel
Copy link
Author

dwenzel commented Jul 20, 2014

Hi @benjaminkott,
sounds good for me. I prefer TypoScript settings anyway.
I will have a look at it soon.
Thank you!

@timpleton
Copy link

Hi @benjaminkott,
I just gave it a try. It works like a charme.
Thank you very much.
You should consider uploading this version to TER so the official introduction package can benefit from it too.

@benjaminkott
Copy link
Owner

Hey @timpleton, as soon i gave it some more tests this can be uploaded to the ter. I want to ensure first that there are no sideeffects and everything works like expected.

@webian
Copy link
Contributor

webian commented Jul 21, 2014

Hi @benjaminkott,
I updated my installation with this commit and your customization of bootstrap (I mean the orange one with Share font) is visible in the FE only after the first hit after a flush of the FE cache:

20140721_205159_610

The next it on any page of the website shows the standard bootstrap css:

20140721_205249_577

Can you give me a hint of a place in the code of this extension where I could start to debug this issue?

Thanks!
ian

@benjaminkott benjaminkott reopened this Jul 21, 2014
@benjaminkott
Copy link
Owner

@webian i was just running also into this issue and i am currently debugging this behaviour and cleaning things up a bit.

its maybe something here
https://github.com/benjaminkott/bootstrap_package/blob/master/Classes/Hooks/PageRendererRender/PreProcessHook.php

or here
https://github.com/benjaminkott/bootstrap_package/blob/master/Classes/Service/CompileService.php

id just said that this need more testing before i can go into ter ;)

@benjaminkott
Copy link
Owner

@webian can you try again please - this should now work correctly, at some point the flattenSetup was missing.

@webian
Copy link
Contributor

webian commented Jul 21, 2014

@benjaminkott problem solved for me too... good job! Thanks :)

@benjaminkott
Copy link
Owner

@webian ok - bootstrap update next then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants