Allow INIReader to read 64-bit integers #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
requested changes
Jul 6, 2023
mayak-dev
changed the title
INIReader::GetBigInteger and INIReader::GetBigUnsignedFixed-width type definitions were already accessible with `<map>` included, but it's nice to include this header anyways.
benhoyt
reviewed
Jul 7, 2023
cpp/INIReader.h
Outdated
| INI_API unsigned long GetUnsigned(const std::string& section, const std::string& name, unsigned long default_value) const; | ||
|
|
||
| // Get an unsigned 64-bit integer (uint64_t) value from INI file, returning default_value if | ||
| // not found or not a valid unsigned integer (decimal "1234", "-1234", or hex "0x4d2"). |
There was a problem hiding this comment.
Let's remove the "-1234" example here, as it's incorrect for unsigned.
benhoyt
requested changes
Jul 7, 2023
benhoyt
approved these changes
Jul 7, 2023
|
Thanks for your contribution. Just tagged release r57. |
|
Awesome! Glad I could contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it may be desired to read (unsigned) integer values outside of the 32-bit bounds. In 32-bit code, however, this might not be the case since doing so by default would cost performance. Rather than changing the types delivered by
INIReader::GetIntegerandINIReader::GetUnsigned, a good way to accommodate is to add separate methods capable of reading (unsigned) 64-bit integers.