Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove leading quote #106

Closed
wants to merge 5 commits into from

Conversation

nolange
Copy link

@nolange nolange commented Jun 17, 2020

No description provided.

If INI_ALLOW_MULTILINE is not defined, then this variable
if not read anywhere.
This will save a call to strlen if this is needed afterwards.
Also dont write to the string in the inner loop, should be faster
on "small" CPUs.
this is intended to allow for ini files that at the same time
are valid toml and/or shell scripts with values containing whitespaces.
@benhoyt
Copy link
Owner

benhoyt commented Jun 18, 2020

Thanks for the contribution. However, inih is a very minimalist library, and I'd rather not start supporting quote-parsing options. Quotes aren't supported by Python's configparser, which is what inih parsing is based on (they're not supported by many other ini parsers either). If people want this, they can just strip the quotes in the app-specific handler function ... or use a full-blown format like TOML or JSON.

@benhoyt benhoyt closed this Jun 18, 2020
@nolange
Copy link
Author

nolange commented Jun 18, 2020

Seems a bit arbitrary, but OK.

The change in question are commits 3 + 4, so I will open another PR with just these removed shortly. (contains some improvements Incl. fix for #107)

@benhoyt
Copy link
Owner

benhoyt commented Jun 18, 2020

Thanks - yep, looking at #107 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants