Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to render a custom overlay on a tile when hover #22

Merged
merged 4 commits into from
Apr 22, 2017

Conversation

ValYouW
Copy link
Contributor

@ValYouW ValYouW commented Apr 20, 2017

What do you think about this? Basically it let user to render their own overlay when hovering an image, this let me do this:
customoverlay

The Image component just renders a full-sized div and setting the opacity based on the hover state, it is the user's responsibility to style the overlay.

Thx

@benhowell
Copy link
Owner

Very nice 👍
Do you have something live I can take a look at?

@ValYouW
Copy link
Contributor Author

ValYouW commented Apr 21, 2017

Not available right now only on my laptop, I'll see if I can put something together on codepen

@benhowell
Copy link
Owner

That'd be great!

@ValYouW
Copy link
Contributor Author

ValYouW commented Apr 21, 2017

Added example to the examples page, you can see it here (towards the end, look for "custom overlay")
https://valyouw.github.io/react-grid-gallery/

@ValYouW
Copy link
Contributor Author

ValYouW commented Apr 21, 2017

Ah, looks like it prevents from LightBox to open....!

@benhowell benhowell merged commit f9e62a5 into benhowell:master Apr 22, 2017
@benhowell
Copy link
Owner

Thanks @ValYouW 👍
I've merged your pull request and will make a few changes and update the demo before I release v0.3.3.

@benhowell
Copy link
Owner

Included in release v0.3.3

@ValYouW
Copy link
Contributor Author

ValYouW commented Apr 22, 2017

Great, Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants