Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests. #93

Merged
merged 10 commits into from
Apr 27, 2020
Merged

Fix broken tests. #93

merged 10 commits into from
Apr 27, 2020

Commits on Mar 8, 2020

  1. Fix uninitalized debugger in JavaEditor. 

    Looks like constructor in Editor called from from JavaEditor is calling an overloaded method back in JavaEditor that expects debugger to have been initialized which is not possible since the parent constructor has not returned. This switches to loading debugger on demand (upon calling getDebugger) which allows for the Editor to use overloaded methods that expect debugger to be initialized.
    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    507e7fa View commit details
    Browse the repository at this point in the history

  2. Require JavaEditor subclass use getDebugger().

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    86b92bc View commit details
    Browse the repository at this point in the history

  3. Made JavaEditor debugger private.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    18653e2 View commit details
    Browse the repository at this point in the history

  4. Made preprocService and debugger visibility consistent in JavaEditor.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    926c458 View commit details
    Browse the repository at this point in the history

  5. Fixed enable debugger on clicking debug button.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    d126c70 View commit details
    Browse the repository at this point in the history

  6. Minor cleanup related to #74.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    3979d9a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Resolved broken tests.

    @sampottinger
    sampottinger committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    45ee436 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. Accept changes on msater for JavaEditor and Debugger.

    @sampottinger
    sampottinger committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    afe01e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into on_demand_debugger

    @sampottinger
    sampottinger committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    f86f3fb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'on_demand_debugger' into restore_tests

    @sampottinger
    sampottinger committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    7e17706 View commit details
    Browse the repository at this point in the history