Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include command/options used to run py-spy in flamegraph output #293

Closed
clokep opened this issue Sep 18, 2020 · 2 comments · Fixed by #359
Closed

Include command/options used to run py-spy in flamegraph output #293

clokep opened this issue Sep 18, 2020 · 2 comments · Fixed by #359

Comments

@clokep
Copy link

clokep commented Sep 18, 2020 •
edited
Loading

I'll frequently run py-spy a few times in a row with slightly different parameters (e.g. with and without --gil, with and without --threads) and then look at them all after the fact. It can be a bit confusing to remember flamegraph is from which run.

It would be convenient if the command used to run py-spy (or the options) was recorded somewhere into the output file. Maybe as the title at the top of the svg?
benfred added a commit that referenced this issue Mar 13, 2021
@benfred
Include commandline used to run py-spy in flamegraph output
db5a2eb 
Set the title of the flamegraph to the full commandline used to run py-spy, rather than just the
py-spy itself

Closes #293
@benfred benfred mentioned this issue Mar 13, 2021
Merged
@benfred
Copy link
Owner

benfred commented Mar 13, 2021

I think this is a great idea - I'm switching the 'py-spy' in the flamegraph svg to be the full commandline in #359

benfred added a commit that referenced this issue Mar 13, 2021
@benfred
Include commandline used to run py-spy in flamegraph output (#359)
1652568 
Set the title of the flamegraph to the full commandline used to run py-spy, rather than just the
py-spy itself

Closes #293
@clokep
Copy link
Author

clokep commented Mar 15, 2021

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include commandline used to run py-spy in flamegraph output benfred/py-spy
2 participants
@benfred @clokep