Cache users groups on demand to prevent multiple sql queries #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed trailing whitespace and tabulation
Several calls to in_group() don't query the database several times anymore. Added a on-demand cache of users_groups that looks like this: [user_id] => array( [group_id] => [group_name], [group2_id] => [group2_name] ) As a new query was added on add_to_group(), on-demand caching of groups was added too. (note: only [group_id] => [group_name]).
|
This looks great! The only issue is all the newline changes. |
|
@benedmunds these aren't newline changes. I've removed trailing whitespaces |
|
Ah ok cool. Thanks, I'll merge this in! |
benedmunds
added a commit
that referenced
this pull request
Sep 20, 2012
Cache users groups on demand to prevent multiple sql queries
|
Great :) I don't know if you saw this, but I didn't change mongo_db, because I don't have any experience on this. I only added the cache vars to compatibility. |
|
I noticed, @sepehr can you take a look at this please? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several calls to
in_group()don't query the database several times anymore.Added a on-demand cache of users_groups that looks like this:
[user_id] => array( [group_id] => [group_name], [group2_id] => [group2_name] )As a new query was added on
add_to_group(), on-demand caching of groups was added too. (note: only[group_id] => [group_name]).Fixes #307