Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explains activation code #1277

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Conversation

Indigo744
Copy link
Contributor

As discussed in #1271

  • Added comment to explains better how activation_code works
  • Modify activate() function to extract the check activation code part, added as check_user_code_activation() function.
  • As a bonus, fix a bug in which event post_activate_successful would not be triggered if an activation code was provided

@benedmunds
Copy link
Owner

This looks good to me.

@phalox can you take a look at this as well for any feedback you have

models/Ion_auth_model.php Outdated Show resolved Hide resolved
@phalox
Copy link

phalox commented Oct 17, 2018

That's looking great, and exactly what I need :-) Let's merge and I'll update my code!

@benedmunds
Copy link
Owner

@Indigo744 is this good to merge? Anything else you want to change?

@Indigo744
Copy link
Contributor Author

@benedmunds No I'm good 😸

@benedmunds benedmunds merged commit a9789e7 into benedmunds:3 Oct 18, 2018
@benedmunds
Copy link
Owner

Merged, thanks to both of you!

@Indigo744 Indigo744 deleted the indigo_activation_comment branch October 18, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants