Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pmap-runner as a temporary measure #63

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

vemv
Copy link
Contributor

@vemv vemv commented Dec 28, 2021

Can help avoid possibly experiencing #56

It can be set via export LEIN_JVM_OPTS="-Dmranderson.internal.no-parallelism=true" and I verified that it's effectively set via a temporary println.

Cheers - V

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #63 (37c2a4b) into master (3a9992c) will increase coverage by 0.06%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   64.25%   64.31%   +0.06%     
==========================================
  Files           7        7              
  Lines         705      709       +4     
  Branches       50       50              
==========================================
+ Hits          453      456       +3     
- Misses        202      203       +1     
  Partials       50       50              
Impacted Files Coverage Δ
src/mranderson/move.clj 91.41% <87.50%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9992c...37c2a4b. Read the comment docs.

@vemv
Copy link
Contributor Author

vemv commented Jan 8, 2022

@benedekfazekas happy new year 🍻

any luck with this one?

@vemv
Copy link
Contributor Author

vemv commented Jan 8, 2022

As a brief commentary, I'm using this in https://github.com/clojure-emacs/enrich-classpath. Its dep tree is so small that non-parallel performance still feels fairly snappy.

@benedekfazekas benedekfazekas merged commit f67a35b into benedekfazekas:master Jan 10, 2022
@vemv vemv deleted the pmap-runner branch January 10, 2022 11:31
@vemv
Copy link
Contributor Author

vemv commented Jan 10, 2022

Thanks! A release would be appreciated.

@vemv
Copy link
Contributor Author

vemv commented Jan 17, 2022

Any luck with a release? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants