Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hapi v18 #29

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Support hapi v18 #29

merged 1 commit into from
Feb 12, 2019

Conversation

sauramirez
Copy link
Contributor

v18 addopted node's move to deprecate its Url.parse() and Url.format() methods
Hapi v18 no longer supports request.url.path

See: hapijs/hapi#3871

v18 addopted node's move to deprecate its `Url.parse()` and `Url.format()` methods
Hapi v18 no longer supports `request.url.path`
@bendrucker bendrucker merged commit 2be4f5c into bendrucker:master Feb 12, 2019
bendrucker pushed a commit that referenced this pull request Feb 12, 2019
v18 addopted node's move to deprecate its `Url.parse()` and `Url.format()` methods
Hapi v18 no longer supports `request.url.path`
@XhmikosR
Copy link

XhmikosR commented Oct 7, 2019

@sauramirez @bendrucker are you sure guys this works with Hapi 18?

PLUGINS: [
  {
    plugin: {
      name: 'vision',
      multiple: true,
      pkg: [Object],
      requirements: [Object],
      register: [Function: register]
    }
  },
  {
    plugin: {
      name: 'inert',
      pkg: [Object],
      once: true,
      requirements: [Object],
      register: [Function: register]
    }
  },
  { register: [Function: register], name: 'hapi-require-https' }
]

@bendrucker
Copy link
Owner

Perhaps not it appears, I would appreciate a fix, otherwise I'll look into it sometime this week

@XhmikosR
Copy link

XhmikosR commented Oct 8, 2019

I'm not very familiar with Hapi's plugin API :/ I just noticed this while trying to use the plugin :)

@bendrucker
Copy link
Owner

This package correctly conforms to the hapi@18 plugin interface and the array you've posted is an acceptable input to server.register. Please open an issue if you still think something's wrong here but AFAICT there's no problem.

Repository owner locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants