-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement deploy to another repository #112
Conversation
Co-authored-by: Marlon James <[email protected]>
Thank you @ktbarrett for updating the previous PR. I'll have a look over the weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this PR. I've added a couple of comments to improve it and also asked a couple of questions.
Additionally, could you add some additional unit tests that would verify this new logic is working as intended?
Hello, I would very much like to use this feature, because I have a private branch that can't have Github pages. Is there a way I can help? |
@Trashtalk217 I'm sure the maintainers don't want a litter of PRs in this repo. You can make the fixes in your fork and can open a PR against this PR's branch in my fork, and it will update this PR. I'm not familiar with typescript and I'm a little busy to learn, so any help is appreciated! |
FYI: I'm picking it up to get it to the finish line |
* only afterJSON
I finally got the CI working and verified that using a separate repository works. I need to clean up the code and add additional workflows to push changes to a separate repo I've created to show as an example |
thank you @ktbarrett for helping with this feature! |
@ktrz And thank you for pushing this through. Seemed like there was more problem than anticipated. We appreciate all your effort. |
Rebase of #37. Closes #36. Closes #61. Closes #87.
I don't know typescript, so feel free to take it and run with it.