Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Elixir 1.2 support #30

Closed
5 tasks done
wasnotrice opened this issue Sep 20, 2016 · 3 comments
Closed
5 tasks done

Drop Elixir 1.2 support #30

wasnotrice opened this issue Sep 20, 2016 · 3 comments
Labels
enhancement
Milestone
0.8.0

Comments

@wasnotrice
Copy link
Collaborator

wasnotrice commented Sep 20, 2016 •
edited by PragTob
Loading

Wait for release of Elixir 1.4

  • Elixir 1.4 has been released
  • Update TODO in Benchee.Formatters.Console.units/1
  • Use keyword type declaration in Benchee.Formatter.Unit
  • Use String.trim/1 instead of String.strip/1
  • use describe blocks in tests a needed
@wasnotrice wasnotrice mentioned this issue Sep 20, 2016
Merged
@PragTob
Copy link
Member

PragTob commented Sep 20, 2016

Edited/added describe blocks

@PragTob
Copy link
Member

PragTob commented Feb 19, 2017

Will probably let the next release still be compatible with Elixir 1.2 and then drop support afterwards.

PragTob added a commit that referenced this issue Apr 25, 2017
@PragTob
Drop elixir 1.2 support
6c3fc61 
* dialyzer on travis was failing with elixir 1.2
* plus see stuff mentioned in #30
PragTob added a commit that referenced this issue Apr 28, 2017
@PragTob
Drop elixir 1.2 support
3df0a15 
* dialyzer on travis was failing with elixir 1.2
* plus see stuff mentioned in #30
@PragTob
Copy link
Member

PragTob commented Apr 29, 2017

Support will be dropped in 0.8.0.

@PragTob PragTob added this to the 0.8.0 milestone May 1, 2017
PragTob added a commit that referenced this issue May 1, 2017
@PragTob
elixir 1.2 leftovers, see #30
04f40e6
@PragTob PragTob mentioned this issue May 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@wasnotrice @PragTob