Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomTextSplitter for the Python package #80

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

benbrandt
Copy link
Owner

Allows for custom text splitting on the Python side. It isn't as nice as implementing the trait on the Rust side, but does make it more flexible.

Allows for custom text splitting on the Python side. It isn't as
nice as implementing the trait on the Rust side, but does make it more
flexible.
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (cb35905) 99.16% compared to head (18023c8) 98.21%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/lib.rs 58.82% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   99.16%   98.21%   -0.96%     
==========================================
  Files           4        4              
  Lines         718      727       +9     
==========================================
+ Hits          712      714       +2     
- Misses          6       13       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbrandt benbrandt merged commit 53cc041 into main Jan 13, 2024
20 of 21 checks passed
@benbrandt benbrandt deleted the custom-python-callback branch January 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant