Stop producing next_sections if we've reached the end of the current semantic level
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t semantic level `next_sections` produces an iterator over the rest of the text at the current semantic level. However, we want to preserve the next highest semantic level starting point as a breakpoint, and not have a chunk traverse across it. This enforces this behavior by limiting the amount of sections that can be iterated over to be before the next level offset.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 97.63% 97.54% -0.09%
==========================================
Files 4 4
Lines 550 571 +21
==========================================
+ Hits 537 557 +20
- Misses 13 14 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next_sectionsproduces an iterator over the rest of the text at the current semantic level.However, we want to preserve the next highest semantic level starting point as a breakpoint, and not have a chunk traverse across it.
This enforces this behavior by limiting the amount of sections that can be iterated over to be before the next level offset.