Reduce allocations, and other optimizations #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since in binary search we need random access to the next sections, we have to allocate a Vec at some point. Rather do this for every chunk, this now reuses the same vec so we can reuse the allocated memory as often as possible.
Does two things: 1. Memoizes the output of `chunk_size`, since this can get called several times on the same chunk in the course of selecting a chunk. 2. Since we are doing this, we no longer need the `sizes` array which tried to do the same thing. 3. Levels in the next semantic chunks now also reuse an allocation. This isn't ideal because it didn't allocate at all before, but was necessary to allow a mutable reference. This does however set things up to also do binary search on the levels.
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
========================================
Coverage 99.28% 99.29%
========================================
Files 6 6
Lines 1404 1561 +157
========================================
+ Hits 1394 1550 +156
- Misses 10 11 +1 ☔ View full report in Codecov by Sentry. |
Only affects markdown ranges, but it wasn't correctly filtering out the correct ranges because it was finding the first item of a level in all ranges, not after the offset
By having inline elements at a higher level than text, it caused for some strange breakpoints. While an inline element can have a text element inside it, this should then be skipped if necessary. It still allows inline elements to be kept together, but also allow for smaller text elements to still get pulled in. This also makes sure that higher semantic levels get preferred if they are shorter in length than a lower level, to avoid the algorithm stopping sooner for a lower level, when a higher level could fit. This also adds an optimization to drop ranges from the caches if we have already moved past them, since these ranges get iterated over quite frequently.
benbrandt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #115